Re: [PATCH 1/2] KVM: x86 emulator: don't update vcpu state if instruction is restarted.

Avi Kivity
2010-08-01T12:17:12Z

On 08/01/2010 01:53 PM, Gleb Natapov wrote:
>
>> That requires everyone to update, or suffer major breakage.
>>
> They will suffer major breakage when they update to a kvm that calls to
> kvm-tpr-opt.c from emulator anyway.

Why?

>>> IIRC it was always this way in emulator. I'd rather fix userspace than
>>> break emulator.
>> It wasn't a problem because the emulator wasn't (and still isn't)
>> used for this. But it has the potential to break badly once we make
>> emulate_invalid_guest_state=1 the default.
>>
> So what can we do about it?
>

Keep the existing behaviour.

--
error compiling committee.c: too many arguments to function