Re: [PATCH 09/15] KVM: x86 emulator: mark mov cr and mov dr as 64-bit instructions in long mode

[Avi Kivity <avi@redhat.com>]

  On 08/01/2010 05:23 PM, Avi Kivity wrote:
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>   arch/x86/kvm/emulate.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index d7d95de..d1a6cd7 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2205,8 +2205,8 @@ static struct opcode twobyte_table[256] = {
>   	/* 0x10 - 0x1F */
>   	N, N, N, N, N, N, N, N, D(ImplicitOps | ModRM), N, N, N, N, N, N, N,
>   	/* 0x20 - 0x2F */
> -	D(ModRM | ImplicitOps | Priv), D(ModRM | Priv),
> -	D(ModRM | ImplicitOps | Priv), D(ModRM | Priv),
> +	D(ModRM | ImplicitOps | Priv | Force64), D(ModRM | Priv | Force64),
> +	D(ModRM | ImplicitOps | Priv | Force64), D(ModRM | Priv | Force64),
>   	N, N, N, N,

This is incorrect.  These instructions are either 32 or 64 bit, while 
Force64 is 64-bit in long mode, and 32/16 bits in other modes, depending 
on default operand size and operand size override.

With this fixed, the whole thing passes autotest.

-- 
error compiling committee.c: too many arguments to function