From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 09/15] KVM: x86 emulator: mark mov cr and mov dr as 64-bit instructions in long mode Date: Mon, 02 Aug 2010 10:37:30 +0300 Message-ID: <4C5675BA.4070801@redhat.com> References: <1280672613-14026-1-git-send-email-avi@redhat.com> <1280672613-14026-10-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org, Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33234 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751346Ab0HBHhc (ORCPT ); Mon, 2 Aug 2010 03:37:32 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o727bVuN006810 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Aug 2010 03:37:31 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o727bVu7018201 for ; Mon, 2 Aug 2010 03:37:31 -0400 In-Reply-To: <1280672613-14026-10-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/01/2010 05:23 PM, Avi Kivity wrote: > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/emulate.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index d7d95de..d1a6cd7 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -2205,8 +2205,8 @@ static struct opcode twobyte_table[256] = { > /* 0x10 - 0x1F */ > N, N, N, N, N, N, N, N, D(ImplicitOps | ModRM), N, N, N, N, N, N, N, > /* 0x20 - 0x2F */ > - D(ModRM | ImplicitOps | Priv), D(ModRM | Priv), > - D(ModRM | ImplicitOps | Priv), D(ModRM | Priv), > + D(ModRM | ImplicitOps | Priv | Force64), D(ModRM | Priv | Force64), > + D(ModRM | ImplicitOps | Priv | Force64), D(ModRM | Priv | Force64), > N, N, N, N, This is incorrect. These instructions are either 32 or 64 bit, while Force64 is 64-bit in long mode, and 32/16 bits in other modes, depending on default operand size and operand size override. With this fixed, the whole thing passes autotest. -- error compiling committee.c: too many arguments to function