From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86 emulator: fix LMSW able to clear cr0.pe Date: Mon, 02 Aug 2010 10:51:33 +0300 Message-ID: <4C567905.6030204@redhat.com> References: <1280720100-2449-1-git-send-email-avi@redhat.com> <4C56783C.6060307@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Marcelo Tosatti To: Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:54950 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753424Ab0HBHvf (ORCPT ); Mon, 2 Aug 2010 03:51:35 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o727pYeQ023104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 2 Aug 2010 03:51:34 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o727pYlV021192 for ; Mon, 2 Aug 2010 03:51:34 -0400 In-Reply-To: <4C56783C.6060307@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/02/2010 10:48 AM, Paolo Bonzini wrote: > On 08/02/2010 05:35 AM, Avi Kivity wrote: >> LMSW is documented not to be able to set cr0.pe; make it so. > > The code is correct, but LMSW is documented not to be able to _clear_ > cr0.pe. :) Right, thinko. -- error compiling committee.c: too many arguments to function