From: Avi Kivity <avi@redhat.com>
To: Gleb Natapov <gleb@redhat.com>
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
Subject: Re: [PATCHv2] KVM: x86 emulator: check io permissions only once for string pio
Date: Mon, 02 Aug 2010 12:52:51 +0300 [thread overview]
Message-ID: <4C569573.2000104@redhat.com> (raw)
In-Reply-To: <20100802094751.GP24773@redhat.com>
On 08/02/2010 12:47 PM, Gleb Natapov wrote:
>
> Do not recheck io permission on every iteration.
>
Applied, thanks.
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index c5878d8..e7e3b50 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -3997,6 +3997,7 @@ int emulate_instruction(struct kvm_vcpu *vcpu,
> memcpy(c->regs, vcpu->arch.regs, sizeof c->regs);
> vcpu->arch.emulate_ctxt.interruptibility = 0;
> vcpu->arch.emulate_ctxt.exception = -1;
> + vcpu->arch.emulate_ctxt.perm_ok = false;
>
This should be in x86_decode_init(), not outside the emulator. I'll
convert it in my next series.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-08-02 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-02 9:47 [PATCHv2] KVM: x86 emulator: check io permissions only once for string pio Gleb Natapov
2010-08-02 9:52 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C569573.2000104@redhat.com \
--to=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox