public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] test: add svm tests
@ 2010-08-02 14:56 Avi Kivity
  2010-08-02 16:57 ` Avi Kivity
  0 siblings, 1 reply; 3+ messages in thread
From: Avi Kivity @ 2010-08-02 14:56 UTC (permalink / raw)
  To: Marcelo Tosatti, kvm

Test behaviour both with svm enabled and with svm disabled.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 kvm/test/x86/unittests.cfg |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/kvm/test/x86/unittests.cfg b/kvm/test/x86/unittests.cfg
index f39c5bd..7796e41 100644
--- a/kvm/test/x86/unittests.cfg
+++ b/kvm/test/x86/unittests.cfg
@@ -53,3 +53,13 @@ file = xsave.flat
 
 [rmap_chain]
 file = rmap_chain.flat
+
+[svm]
+file = svm.flat
+smp = 2
+extra_params = -enable-nesting -cpu qemu64,+svm
+
+[svm-disabled]
+file = svm.flat
+smp = 2
+extra_params = -cpu qemu64,-svm
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: add svm tests
  2010-08-02 14:56 [PATCH] test: add svm tests Avi Kivity
@ 2010-08-02 16:57 ` Avi Kivity
  2010-08-02 17:31   ` Lucas Meneghel Rodrigues
  0 siblings, 1 reply; 3+ messages in thread
From: Avi Kivity @ 2010-08-02 16:57 UTC (permalink / raw)
  To: Marcelo Tosatti, kvm, Lucas Meneghel Rodrigues

  On 08/02/2010 05:56 PM, Avi Kivity wrote:
> Test behaviour both with svm enabled and with svm disabled.
>
> Signed-off-by: Avi Kivity<avi@redhat.com>
> ---
>   kvm/test/x86/unittests.cfg |   10 ++++++++++
>   1 files changed, 10 insertions(+), 0 deletions(-)
>
> diff --git a/kvm/test/x86/unittests.cfg b/kvm/test/x86/unittests.cfg
> index f39c5bd..7796e41 100644
> --- a/kvm/test/x86/unittests.cfg
> +++ b/kvm/test/x86/unittests.cfg
> @@ -53,3 +53,13 @@ file = xsave.flat
>
>   [rmap_chain]
>   file = rmap_chain.flat
> +
> +[svm]
> +file = svm.flat
> +smp = 2
> +extra_params = -enable-nesting -cpu qemu64,+svm
> +
> +[svm-disabled]
> +file = svm.flat
> +smp = 2
> +extra_params = -cpu qemu64,-svm

This doesn't appear to work.  The test is run, but smp and extra_params 
are ignored:

08/02 19:51:05 DEBUG|    kvm_vm:0637| Running qemu command:
/root/autotest/client/tests/kvm/qemu -name 'vm1' -monitor 
unix:'/tmp/monitor-humanmonitor1-20100802-194922-fika',server,nowait 
-serial unix:'/tmp/serial-20100802-194922-fika',server,nowait -m 512 
-kernel '/root/autotest/client/tests/kvm/unittests/svm.flat' -vnc :0 
-chardev file,id=testlog,path=/tmp/testlog-20100802-194922-fika -device 
testdev,chardev=testlog  -S


-- 
error compiling committee.c: too many arguments to function


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] test: add svm tests
  2010-08-02 16:57 ` Avi Kivity
@ 2010-08-02 17:31   ` Lucas Meneghel Rodrigues
  0 siblings, 0 replies; 3+ messages in thread
From: Lucas Meneghel Rodrigues @ 2010-08-02 17:31 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, kvm

On Mon, 2010-08-02 at 19:57 +0300, Avi Kivity wrote:
> On 08/02/2010 05:56 PM, Avi Kivity wrote:
> > Test behaviour both with svm enabled and with svm disabled.
> >
> > Signed-off-by: Avi Kivity<avi@redhat.com>
> > ---
> >   kvm/test/x86/unittests.cfg |   10 ++++++++++
> >   1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/kvm/test/x86/unittests.cfg b/kvm/test/x86/unittests.cfg
> > index f39c5bd..7796e41 100644
> > --- a/kvm/test/x86/unittests.cfg
> > +++ b/kvm/test/x86/unittests.cfg
> > @@ -53,3 +53,13 @@ file = xsave.flat
> >
> >   [rmap_chain]
> >   file = rmap_chain.flat
> > +
> > +[svm]
> > +file = svm.flat
> > +smp = 2
> > +extra_params = -enable-nesting -cpu qemu64,+svm
> > +
> > +[svm-disabled]
> > +file = svm.flat
> > +smp = 2
> > +extra_params = -cpu qemu64,-svm
> 
> This doesn't appear to work.  The test is run, but smp and extra_params 
> are ignored:
> 
> 08/02 19:51:05 DEBUG|    kvm_vm:0637| Running qemu command:
> /root/autotest/client/tests/kvm/qemu -name 'vm1' -monitor 
> unix:'/tmp/monitor-humanmonitor1-20100802-194922-fika',server,nowait 
> -serial unix:'/tmp/serial-20100802-194922-fika',server,nowait -m 512 
> -kernel '/root/autotest/client/tests/kvm/unittests/svm.flat' -vnc :0 
> -chardev file,id=testlog,path=/tmp/testlog-20100802-194922-fika -device 
> testdev,chardev=testlog  -S

Ok, my fault, I have fixed it and just sent a patch upstream. Will
commit soon and rebase the internal test tree afterwards.

Sorry and thanks for pointing this out!

Lucas


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-02 17:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-02 14:56 [PATCH] test: add svm tests Avi Kivity
2010-08-02 16:57 ` Avi Kivity
2010-08-02 17:31   ` Lucas Meneghel Rodrigues

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox