From: Paolo Bonzini <pbonzini@redhat.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86 emulator: cleanup for BitOp instruction emulation
Date: Wed, 04 Aug 2010 11:26:47 +0200 [thread overview]
Message-ID: <4C593257.2090702@redhat.com> (raw)
In-Reply-To: <4C592C55.8080607@cn.fujitsu.com>
On 08/04/2010 11:01 AM, Wei Yongjun wrote:
> Signed-off-by: Wei Yongjun<yjwei@cn.fujitsu.com>
> ---
> arch/x86/kvm/emulate.c | 12 ++++--------
> 1 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
> index eba5a67..c05a5d7 100644
> --- a/arch/x86/kvm/emulate.c
> +++ b/arch/x86/kvm/emulate.c
> @@ -2545,6 +2545,10 @@ done_prefixes:
> break;
> }
>
> + /* Only subword offset for BitOp: bt/bts/btr/btc. */
> + if (c->d& BitOp)
> + c->src.val&= (c->op_bytes<< 3) - 1;
> +
You are doing this before the destination operand is decoded, which
means you are not adjusting a memory operand anymore if c->src.val >
(c->op_bytes * 8).
Paolo
next prev parent reply other threads:[~2010-08-04 9:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-04 8:27 [PATCH] KVM: x86 emulator: fix group 8 instruction decoding Wei Yongjun
2010-08-04 9:01 ` [PATCH] KVM: x86 emulator: cleanup for BitOp instruction emulation Wei Yongjun
2010-08-04 9:26 ` Paolo Bonzini [this message]
2010-08-04 9:36 ` Wei Yongjun
2010-08-04 9:37 ` [PATCHv2] " Wei Yongjun
2010-08-04 9:45 ` Paolo Bonzini
2010-08-04 9:41 ` [PATCH] KVM: x86 emulator: fix group 8 instruction decoding Paolo Bonzini
2010-08-05 6:07 ` [PATCHv3] KVM: x86 emulator: fix BitOp instruction emulation Wei Yongjun
2010-08-05 9:05 ` [PATCH] KVM: x86 emulator: fix group 8 instruction decoding Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C593257.2090702@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox