From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Subject: Re: [PATCH] KVM: x86 emulator: cleanup for BitOp instruction emulation
Date: Wed, 04 Aug 2010 17:36:18 +0800
Message-ID: <4C593492.1050008@cn.fujitsu.com>
References: <4C592470.1010608@cn.fujitsu.com> <4C592C55.8080607@cn.fujitsu.com> <4C593257.2090702@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
To: Paolo Bonzini <pbonzini@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from cn.fujitsu.com ([222.73.24.84]:59012 "EHLO song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1756874Ab0HDJiS (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 4 Aug 2010 05:38:18 -0400
In-Reply-To: <4C593257.2090702@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>


> On 08/04/2010 11:01 AM, Wei Yongjun wrote:
>   
>> Signed-off-by: Wei Yongjun<yjwei@cn.fujitsu.com>
>> ---
>>   arch/x86/kvm/emulate.c |   12 ++++--------
>>   1 files changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
>> index eba5a67..c05a5d7 100644
>> --- a/arch/x86/kvm/emulate.c
>> +++ b/arch/x86/kvm/emulate.c
>> @@ -2545,6 +2545,10 @@ done_prefixes:
>>   		break;
>>   	}
>>
>> +	/* Only subword offset for BitOp: bt/bts/btr/btc. */
>> +	if (c->d&  BitOp)
>> +		c->src.val&= (c->op_bytes<<  3) - 1;
>> +
>>     
> You are doing this before the destination operand is decoded, which
> means you are not adjusting a memory operand anymore if c->src.val >
> (c->op_bytes * 8).
>   

Oh, I forgot this, I will fix it, thanks.