* [PATCH] KVM: x86 emulator: simplify two-byte opcode check
@ 2010-08-05 8:34 Wei Yongjun
2010-08-05 8:48 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2010-08-05 8:34 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm
Two-byte opcode always start with 0x0F and the decode flags
of opcode 0xF0 is always 0, so remove dup check.
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
arch/x86/kvm/emulate.c | 12 +++++-------
1 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index 8763708..a465823 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -2405,13 +2405,11 @@ done_prefixes:
/* Opcode byte(s). */
opcode = opcode_table[c->b];
- if (opcode.flags == 0) {
- /* Two-byte opcode? */
- if (c->b == 0x0f) {
- c->twobyte = 1;
- c->b = insn_fetch(u8, 1, c->eip);
- opcode = twobyte_table[c->b];
- }
+ /* Two-byte opcode? */
+ if (c->b == 0x0f) {
+ c->twobyte = 1;
+ c->b = insn_fetch(u8, 1, c->eip);
+ opcode = twobyte_table[c->b];
}
c->d = opcode.flags;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86 emulator: simplify two-byte opcode check
2010-08-05 8:34 [PATCH] KVM: x86 emulator: simplify two-byte opcode check Wei Yongjun
@ 2010-08-05 8:48 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-08-05 8:48 UTC (permalink / raw)
To: Wei Yongjun; +Cc: kvm
On 08/05/2010 11:34 AM, Wei Yongjun wrote:
> Two-byte opcode always start with 0x0F and the decode flags
> of opcode 0xF0 is always 0, so remove dup check.
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-05 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-05 8:34 [PATCH] KVM: x86 emulator: simplify two-byte opcode check Wei Yongjun
2010-08-05 8:48 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox