From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: x86 emulator: fix group 8 instruction decoding Date: Thu, 05 Aug 2010 12:05:56 +0300 Message-ID: <4C5A7EF4.5000603@redhat.com> References: <4C592470.1010608@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, Paolo Bonzini To: Wei Yongjun Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11137 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758861Ab0HEJGG (ORCPT ); Thu, 5 Aug 2010 05:06:06 -0400 In-Reply-To: <4C592470.1010608@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/04/2010 11:27 AM, Wei Yongjun wrote: > Group 8 instruction, BT[S|R|C] should be mask as BitOp. > Please repost as a patch set, all those versions confuse me. For maximum reviewability, please do: - a patch that consolidates existing register BitOp decoding - a patch that adds immediate BitOp decoding - a patch that adds BitOp to 0f ba -- error compiling committee.c: too many arguments to function