From: Avi Kivity <avi@redhat.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"seabios@seabios.org" <seabios@seabios.org>,
"Kevin O'Connor" <kevin@koconnor.net>,
"Jiang, Yunhong" <yunhong.jiang@intel.com>,
"Li, Xin" <xin.li@intel.com>,
"Zheng, Shaohui" <shaohui.zheng@intel.com>,
"You, Yongkang" <yongkang.you@intel.com>
Subject: Re: [PATCH] Fix bug for vcpu hotplug
Date: Sun, 15 Aug 2010 15:06:28 +0300 [thread overview]
Message-ID: <4C67D844.5060306@redhat.com> (raw)
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E0B0007F9DC@shsmsx502.ccr.corp.intel.com>
On 08/06/2010 06:36 AM, Liu, Jinsong wrote:
> Recently seabios implement vcpu hotplug infrastructure.
> During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd.
> This patch is to fix the bug, mark bus->allow_hotplug as 1 after qdev_hotplug init done.
Please copy qemu-devel on qemu patches.
> @@ -117,6 +117,9 @@ DeviceState *qdev_create(BusState *bus, const char *name)
> hw_error("Unknown device '%s' for bus '%s'\n", name, bus->info->name);
> }
>
> + if (qdev_hotplug)
> + bus->allow_hotplug = 1;
> +
> return qdev_create_from_info(bus, info);
> }
Doesn't seem right - this will set allow_hotplug on all busses.
It needs to be set only on the system bus (hw/sysbus.c).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-15 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-06 3:36 [PATCH] Fix bug for vcpu hotplug Liu, Jinsong
2010-08-15 12:06 ` Avi Kivity [this message]
2010-08-18 7:17 ` Liu, Jinsong
2010-08-18 7:33 ` Avi Kivity
2010-08-19 15:24 ` [Qemu-devel] " Anthony Liguori
2010-08-19 15:34 ` Avi Kivity
2010-08-19 19:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C67D844.5060306@redhat.com \
--to=avi@redhat.com \
--cc=jinsong.liu@intel.com \
--cc=kevin@koconnor.net \
--cc=kvm@vger.kernel.org \
--cc=seabios@seabios.org \
--cc=shaohui.zheng@intel.com \
--cc=xin.li@intel.com \
--cc=yongkang.you@intel.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).