From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] x86: Bail out on unemulated instructions Date: Sun, 15 Aug 2010 18:58:06 +0300 Message-ID: <4C680E8E.2090001@redhat.com> References: <1281801094-4515-1-git-send-email-m.gamal005@gmail.com> <1281801094-4515-2-git-send-email-m.gamal005@gmail.com> <20100815073236.GP10499@redhat.com> <20100815124112.GR10499@redhat.com> <20100815124900.GS10499@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mohammed Gamal , mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:1874 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758299Ab0HOP6K (ORCPT ); Sun, 15 Aug 2010 11:58:10 -0400 In-Reply-To: <20100815124900.GS10499@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/15/2010 03:49 PM, Gleb Natapov wrote: >> >> True. Can we do it for real mode in general (i.e. X86EMUL_MODE_REAL)? > If we flush all shadow pages when moving from paged mode to non paged > checking for X86EMUL_MODE_REAL sounds enough to me, but Avi knows better. > Or we can add is_big_real_mode() callback to x86_ops and implement it in > vmx accordingly. Neither are possible. We can have one cpu in big real mode and others in paged mode, so even in real mode we cannot rule out a spurious page fault due to shadow write protection. -- error compiling committee.c: too many arguments to function