From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH v3 0/4] Real mode interrupt injection Date: Mon, 16 Aug 2010 17:16:01 +0300 Message-ID: <4C694821.1020108@redhat.com> References: <1281908823-4505-1-git-send-email-m.gamal005@gmail.com> <4C693ACA.9090702@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, mtosatti@redhat.com To: Mohammed Gamal Return-path: Received: from mx1.redhat.com ([209.132.183.28]:56528 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754251Ab0HPOQE (ORCPT ); Mon, 16 Aug 2010 10:16:04 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/16/2010 04:28 PM, Mohammed Gamal wrote: > >> I debugged this for a bit - emulate_int_real() is completely broken. >> emulate_push() doesn't push anything, it only schedules a push; running >> these back-to-back will result in only the last push to be executed. >> > So we need write back the decode cache after each push. Or let > emulate_push() change the emulation context directly. Please CMIIW I wrote a push_std() that uses ->write_std() instead of ->write_emulated() and can be used back-to-back. Long term we'll need a write queue but for the short term this will do. I'll clean up my patches and push them later on. -- error compiling committee.c: too many arguments to function