From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH v3 0/4] Real mode interrupt injection Date: Mon, 16 Aug 2010 17:47:56 +0300 Message-ID: <4C694F9C.6040803@redhat.com> References: <1281908823-4505-1-git-send-email-m.gamal005@gmail.com> <4C693ACA.9090702@redhat.com> <4C694821.1020108@redhat.com> <20100816142923.GA21482@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Mohammed Gamal , kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:29886 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754529Ab0HPOr7 (ORCPT ); Mon, 16 Aug 2010 10:47:59 -0400 In-Reply-To: <20100816142923.GA21482@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/16/2010 05:29 PM, Gleb Natapov wrote: > >> I wrote a push_std() that uses ->write_std() instead of >> ->write_emulated() and can be used back-to-back. Long term we'll >> need a write queue but for the short term this will do. >> > Why not just call writeback() after the emulate_push()? emulate_pusha() > does it. Good idea. I'll do that. -- error compiling committee.c: too many arguments to function