From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC PATCH v3 0/4] Real mode interrupt injection Date: Mon, 16 Aug 2010 18:33:28 +0300 Message-ID: <4C695A48.8070208@redhat.com> References: <1281908823-4505-1-git-send-email-m.gamal005@gmail.com> <4C693ACA.9090702@redhat.com> <4C694821.1020108@redhat.com> <20100816142923.GA21482@redhat.com> <4C694F9C.6040803@redhat.com> <20100816153133.GB21482@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: Mohammed Gamal , kvm@vger.kernel.org, mtosatti@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:23265 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753434Ab0HPPdb (ORCPT ); Mon, 16 Aug 2010 11:33:31 -0400 In-Reply-To: <20100816153133.GB21482@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/16/2010 06:31 PM, Gleb Natapov wrote: > On Mon, Aug 16, 2010 at 06:23:18PM +0300, Mohammed Gamal wrote: >> On Mon, Aug 16, 2010 at 5:47 PM, Avi Kivity wrote: >>> On 08/16/2010 05:29 PM, Gleb Natapov wrote: >>>>> I wrote a push_std() that uses ->write_std() instead of >>>>> ->write_emulated() and can be used back-to-back. Long term we'll >>>>> need a write queue but for the short term this will do. >>>>> >>>> Why not just call writeback() after the emulate_push()? emulate_pusha() >>>> does it. >>> Good idea. I'll do that. >> I tried it, but it doesn't seem to make any difference. >> > It should. Can you post what you've tried? > There are other bugs involved. I'll post a patchset soon. -- error compiling committee.c: too many arguments to function