kvm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] KVM: PIT: free irq source id in handling error path
@ 2010-07-20  6:26 Xiao Guangrong
  2010-08-17  7:02 ` [PATCH RESEND] " Xiao Guangrong
  0 siblings, 1 reply; 3+ messages in thread
From: Xiao Guangrong @ 2010-07-20  6:26 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, LKML, KVM list

Free irq source id if create pit workqueue fail

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
 arch/x86/kvm/i8254.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
index 0fd6378..211716f 100644
--- a/arch/x86/kvm/i8254.c
+++ b/arch/x86/kvm/i8254.c
@@ -697,6 +697,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
 	pit->wq = create_singlethread_workqueue("kvm-pit-wq");
 	if (!pit->wq) {
 		mutex_unlock(&pit->pit_state.lock);
+		kvm_free_irq_source_id(kvm, pit->irq_source_id);
 		kfree(pit);
 		return NULL;
 	}
-- 
1.6.1.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH RESEND] KVM: PIT: free irq source id in handling error path
  2010-07-20  6:26 [PATCH] KVM: PIT: free irq source id in handling error path Xiao Guangrong
@ 2010-08-17  7:02 ` Xiao Guangrong
  2010-08-17  9:04   ` Avi Kivity
  0 siblings, 1 reply; 3+ messages in thread
From: Xiao Guangrong @ 2010-08-17  7:02 UTC (permalink / raw)
  Cc: Avi Kivity, Marcelo Tosatti, LKML, KVM list

Free irq source id if create pit workqueue fail

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---
 arch/x86/kvm/i8254.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
index 0fd6378..211716f 100644
--- a/arch/x86/kvm/i8254.c
+++ b/arch/x86/kvm/i8254.c
@@ -697,6 +697,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
 	pit->wq = create_singlethread_workqueue("kvm-pit-wq");
 	if (!pit->wq) {
 		mutex_unlock(&pit->pit_state.lock);
+		kvm_free_irq_source_id(kvm, pit->irq_source_id);
 		kfree(pit);
 		return NULL;
 	}
-- 
1.6.1.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH RESEND] KVM: PIT: free irq source id in handling error path
  2010-08-17  7:02 ` [PATCH RESEND] " Xiao Guangrong
@ 2010-08-17  9:04   ` Avi Kivity
  0 siblings, 0 replies; 3+ messages in thread
From: Avi Kivity @ 2010-08-17  9:04 UTC (permalink / raw)
  To: Xiao Guangrong

  On 08/17/2010 10:02 AM, Xiao Guangrong wrote:
> Free irq source id if create pit workqueue fail
>

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-17  9:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-20  6:26 [PATCH] KVM: PIT: free irq source id in handling error path Xiao Guangrong
2010-08-17  7:02 ` [PATCH RESEND] " Xiao Guangrong
2010-08-17  9:04   ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).