* [PATCH] KVM: x86 emulator: remove useless label from x86_emulate_insn()
@ 2010-08-06 7:36 Wei Yongjun
2010-08-17 9:40 ` Avi Kivity
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2010-08-06 7:36 UTC (permalink / raw)
To: Avi Kivity; +Cc: kvm
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
arch/x86/kvm/emulate.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c
index dc6a74e..a755b85 100644
--- a/arch/x86/kvm/emulate.c
+++ b/arch/x86/kvm/emulate.c
@@ -2760,16 +2760,12 @@ x86_emulate_insn(struct x86_emulate_ctxt *ctxt)
c->eip = ctxt->eip;
}
- if (c->src.type == OP_MEM) {
- if (c->d & NoAccess)
- goto no_fetch;
+ if ((c->src.type == OP_MEM) && !(c->d & NoAccess)) {
rc = read_emulated(ctxt, ops, c->src.addr.mem,
c->src.valptr, c->src.bytes);
if (rc != X86EMUL_CONTINUE)
goto done;
c->src.orig_val = c->src.val;
- no_fetch:
- ;
}
if (c->src2.type == OP_MEM) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86 emulator: remove useless label from x86_emulate_insn()
2010-08-06 7:36 [PATCH] KVM: x86 emulator: remove useless label from x86_emulate_insn() Wei Yongjun
@ 2010-08-17 9:40 ` Avi Kivity
0 siblings, 0 replies; 2+ messages in thread
From: Avi Kivity @ 2010-08-17 9:40 UTC (permalink / raw)
To: Wei Yongjun; +Cc: kvm
On 08/06/2010 10:36 AM, Wei Yongjun wrote:
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Applied, thanks.
--
error compiling committee.c: too many arguments to function
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-17 9:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-06 7:36 [PATCH] KVM: x86 emulator: remove useless label from x86_emulate_insn() Wei Yongjun
2010-08-17 9:40 ` Avi Kivity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).