From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/3] device-assignment: PCI option ROM fixes Date: Tue, 17 Aug 2010 12:49:01 +0300 Message-ID: <4C6A5B0D.5060700@redhat.com> References: <20100730193941.10110.92913.stgit@localhost6.localdomain6> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, ddutile@redhat.com, chrisw@redhat.com, gleb@redhat.com To: Alex Williamson Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24994 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752371Ab0HQJtD (ORCPT ); Tue, 17 Aug 2010 05:49:03 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7H9n3CB020657 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Aug 2010 05:49:03 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7H9n2RR010274 for ; Tue, 17 Aug 2010 05:49:02 -0400 In-Reply-To: <20100730193941.10110.92913.stgit@localhost6.localdomain6> Sender: kvm-owner@vger.kernel.org List-ID: On 07/30/2010 10:40 PM, Alex Williamson wrote: > Changeset b4f8c249 in kvm.git makes the mprotects in device assignment > produce a "Bad address" hang when a device with an option ROM is > assigned. We can avoid this by just using the slow mapping path since > ROM access doesn't need to be fast. Apparently nobody has ever mapped > a ROM via this path, because passing NULL to cpu_register_io_memory() > doesn't work. I also found we're overly restrictive in copying the > ROM from the host, I must have been lucky and had a ROM that matched > the BAR size when I added this. Applied, thanks. -- error compiling committee.c: too many arguments to function