From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH] Fix bug for vcpu hotplug
Date: Wed, 18 Aug 2010 10:33:28 +0300
Message-ID: <4C6B8CC8.3040200@redhat.com>
References: <BC00F5384FCFC9499AF06F92E8B78A9E0B0007F9DC@shsmsx502.ccr.corp.intel.com> <4C67D844.5060306@redhat.com> <BC00F5384FCFC9499AF06F92E8B78A9E164C8CB831@shsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Jiang, Yunhong" <yunhong.jiang@intel.com>,
	"Yang, Sheng" <sheng.yang@intel.com>, "Li, Xin" <xin.li@intel.com>
To: "Liu, Jinsong" <jinsong.liu@intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:55428 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750785Ab0HRHdg (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 18 Aug 2010 03:33:36 -0400
In-Reply-To: <BC00F5384FCFC9499AF06F92E8B78A9E164C8CB831@shsmsx502.ccr.corp.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 08/18/2010 10:17 AM, Liu, Jinsong wrote:
> During test, we found qemu-kvm has a bug result in guestos shutdown when vcpu hotadd.
> This patch is to fix the bug, allow hotplug for sysbus qdev.
>
> --- a/hw/qdev.c
> +++ b/hw/qdev.c
> @@ -108,6 +108,7 @@ DeviceState *qdev_create(BusState *bus, const char *name)
>       if (!bus) {
>           if (!main_system_bus) {
>               main_system_bus = qbus_create(&system_bus_info, NULL, "main-system-bus");
> +            main_system_bus->allow_hotplug = 1;
>           }
>           bus = main_system_bus;
>       }


Looks reasonable to me.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.