Re: [PATCH] Add realmode test for jcxz instruction

[Avi Kivity <avi@redhat.com>]

 On 08/19/2010 09:28 AM, Wei Yongjun wrote:
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
>
> diff --git a/x86/realmode.c b/x86/realmode.c
> index ce8fb18..0caf388 100644
> --- a/x86/realmode.c
> +++ b/x86/realmode.c
> @@ -1262,6 +1262,32 @@ void test_cbw(void)
>  		print_serial("cwde test 1: PASS\n");
>  }
>  
> +void test_jcxz(void)
> +{
> +	struct regs inregs = { 0 }, outregs;
> +
> +	MK_INSN(jcxz, "jcxz 1f\n\t"
> +		      "mov $0x1234, %eax\n\t"
> +		      "1:\n\t");
> +	MK_INSN(jecxz, "jecxz 1f\n\t"
> +		       "mov $0x1234, %eax\n\t"
> +		       "1:\n\t");
> +
> +	exec_in_big_real_mode(&inregs, &outregs,
> +			insn_jcxz, insn_jcxz_end - insn_jcxz);
> +	if(!regs_equal(&inregs, &outregs, 0))
> +		print_serial("JCXZ short Test 1: FAIL\n");
> +	else
> +		print_serial("JCXZ short Test 1: PASS\n");
> +
> +	exec_in_big_real_mode(&inregs, &outregs,
> +			insn_jecxz, insn_jecxz_end - insn_jecxz);
> +	if(!regs_equal(&inregs, &outregs, 0))
> +		print_serial("JECXZ short Test 1: FAIL\n");
> +	else
> +		print_serial("JECXZ short Test 1: PASS\n");
> +}
> +

What about tests for jump-not-taken?

As a bonus, check jcxz with ecx=0x10000 and jecxz with ecx=0x10000.

-- 
error compiling committee.c: too many arguments to function