From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4 v2] kvm: rework KVM mmu_shrink() code Date: Sun, 22 Aug 2010 18:29:39 +0300 Message-ID: <4C714263.8060102@redhat.com> References: <20100820011054.GA11297@tpepper-t61p.dolavim.us> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , Lai Jiangshan , Dave Hansen , LKML , kvm@vger.kernel.org To: Tim Pepper Return-path: In-Reply-To: <20100820011054.GA11297@tpepper-t61p.dolavim.us> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 08/20/2010 04:10 AM, Tim Pepper wrote: > The following series is the four patches Dave Hansen had queued for test > as mentioned last week in the thread: > "[PATCH] kvm: make mmu_shrink() fit shrinker's requirement" > Last week just before leaving for vacation Dave had noted in that thread > that these four were ready to merge based on our perf team's testing > finally having wrapped up. But it turns out he hadn't actually posted > them after refactoring in response to comments back in June... > > I'm covering for him in his absence and had previously reviewed this set. > This version contains fixes in response to the comments in June. The > patches are pulled straight from Dave's development tree, as tested, with > a minor build/merge change to patch #3 which was otherwise inadvertantly > re-introducing an (unused) variable that Avi more recently had removed. > > Compared to the previous version from June: > - patch #3 addresses Marcelo's comment about a double deaccounting > of kvm->arch.n_used_mmu_pages > - patch #4 includes protection of the used mmu page counts in response to > Avi's comments > > Avi: if Dave's use of a per cpu counter in the refactored patch #4 is > acceptable to you, then the series is for merging. > Applied, thanks for taking care of this. -- error compiling committee.c: too many arguments to function