From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christian Borntraeger <borntraeger@de.ibm.com>
Subject: Re: [PATCH 1/2] S390: take a full byte as ext_param indicator
Date: Tue, 24 Aug 2010 14:14:04 +0200
Message-ID: <4C73B78C.2030003@de.ibm.com>
References: <1282599077-29857-1-git-send-email-agraf@suse.de> <4C736EAF.9020107@de.ibm.com> <4C73B5C1.5040603@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: virtualization@lists.linux-foundation.org,
	Rusty Russell <rusty@rustcorp.com.au>,
	Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>,
	Carsten Otte <carsteno@de.ibm.com>,
	KVM list <kvm@vger.kernel.org>
To: Alexander Graf <agraf@suse.de>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mtagate4.de.ibm.com ([195.212.17.164]:35664 "EHLO
	mtagate4.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751661Ab0HXMOH (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 24 Aug 2010 08:14:07 -0400
Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49])
	by mtagate4.de.ibm.com (8.13.1/8.13.1) with ESMTP id o7OCE5qQ023754
	for <kvm@vger.kernel.org>; Tue, 24 Aug 2010 12:14:05 GMT
Received: from d12av01.megacenter.de.ibm.com (d12av01.megacenter.de.ibm.com [9.149.165.212])
	by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o7OCE5i23887188
	for <kvm@vger.kernel.org>; Tue, 24 Aug 2010 14:14:05 +0200
Received: from d12av01.megacenter.de.ibm.com (loopback [127.0.0.1])
	by d12av01.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o7OCE4Mb023002
	for <kvm@vger.kernel.org>; Tue, 24 Aug 2010 14:14:05 +0200
In-Reply-To: <4C73B5C1.5040603@suse.de>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

Am 24.08.2010 14:06, schrieb Alexander Graf:
>>>  #define VIRTIO_SUBCODE_64 0x0D00
>>> +#define VIRTIO_PARAM_MASK		0xff
>>> +#define VIRTIO_PARAM_VRING_INTERRUPT	0x0
>>> +#define VIRTIO_PARAM_CONFIG_CHANGED	0x1
>>>     
>>
>> Maybe this should be exported in a header, something like 
>> arch/s390/include/asm/kvm_virtio.h? In that case this file
>> must be added to Kbuild for make headers_install.
>>   
> 
> While that thought sounds good at first, it's really no use for anyone,
> right? I mean - in qemu we need to define the defines manually anyways
> because we need to potentially be able to build the s390x target on
> non-s390x, possibly on non-Linux.

I have no strong opinion on that, but I think its more a matter of where
to put an interface description. A header file seems just the right place.
I will let you (or Rusty) decide.