From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/2] S390: take a full byte as ext_param indicator Date: Tue, 24 Aug 2010 15:22:22 +0300 Message-ID: <4C73B97E.2060303@redhat.com> References: <1282599077-29857-1-git-send-email-agraf@suse.de> <4C736EAF.9020107@de.ibm.com> <4C73B5C1.5040603@suse.de> <4C73B78C.2030003@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alexander Graf , virtualization@lists.linux-foundation.org, Rusty Russell , Christian Ehrhardt , Carsten Otte , KVM list To: Christian Borntraeger Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25672 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751460Ab0HXMWi (ORCPT ); Tue, 24 Aug 2010 08:22:38 -0400 In-Reply-To: <4C73B78C.2030003@de.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/24/2010 03:14 PM, Christian Borntraeger wrote: > > I have no strong opinion on that, but I think its more a matter of where > to put an interface description. A header file seems just the right place. > I will let you (or Rusty) decide. First of all we need a virtio/s390 specification, like we have a virtio/pci spec. Second, I agree it should be in an exported header file, even if qemu doesn't make use of it. It's an interface and should be exported. -- error compiling committee.c: too many arguments to function