From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/3] KVM: x86 emulator: get rid of "restart" in emulation context. Date: Tue, 24 Aug 2010 17:28:12 +0300 Message-ID: <4C73D6FC.8020405@redhat.com> References: <1282649455-9463-1-git-send-email-gleb@redhat.com> <1282649455-9463-3-git-send-email-gleb@redhat.com> <4C73C582.6050704@redhat.com> <20100824133754.GC10499@redhat.com> <4C73CBF6.1050809@redhat.com> <20100824135255.GD10499@redhat.com> <4C73D0A6.5000900@redhat.com> <20100824140610.GE10499@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:12103 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754087Ab0HXO2O (ORCPT ); Tue, 24 Aug 2010 10:28:14 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7OESE4Y005877 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 24 Aug 2010 10:28:14 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7OESDe5009665 for ; Tue, 24 Aug 2010 10:28:14 -0400 In-Reply-To: <20100824140610.GE10499@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/24/2010 05:06 PM, Gleb Natapov wrote: > On Tue, Aug 24, 2010 at 05:01:10PM +0300, Avi Kivity wrote: >> On 08/24/2010 04:52 PM, Gleb Natapov wrote: >>> We can, of course. But for me it looks as arbitrary as -1/0/1 since not >>> all enum values have meanings to the caller. >> Yeah. -1/0/1's problem is that between reading the callee code and >> caller code, I manage to forget what the values mean. >> > Luckily we have only one caller of x86_emulate_insn(), so documenting > return values right where function is called should help. :) Please use #define instead of /* */. -- error compiling committee.c: too many arguments to function