public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] Add realmode test for CALL FAR IMM instruction
Date: Wed, 25 Aug 2010 09:50:47 +0300	[thread overview]
Message-ID: <4C74BD47.5030101@redhat.com> (raw)
In-Reply-To: <4C74B526.1040205@cn.fujitsu.com>

 On 08/25/2010 09:16 AM, Wei Yongjun wrote:
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
> ---
>  x86/realmode.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/x86/realmode.c b/x86/realmode.c
> index a833829..2e12680 100644
> --- a/x86/realmode.c
> +++ b/x86/realmode.c
> @@ -437,6 +437,9 @@ void test_call(void)
>  			    "ret\n\t"
>  			    "2:\t");
>  	MK_INSN(call_far1,  "lcallw *(%ebx)\n\t");
> +	MK_INSN(call_far2,  ".byte 0x9a\n\t"
> +			    ".word retf\n\t"
> +			    ".word 0x00\n\t");

Why .byte encoding? won't "lcallw $0, $retf" (or the other way round) work?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.


  reply	other threads:[~2010-08-25  6:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-25  6:10 [PATCH] KVM: x86 emulator: add CALL FAR instruction emulation (opcode 9a) Wei Yongjun
2010-08-25  6:16 ` [PATCH] Add realmode test for CALL FAR IMM instruction Wei Yongjun
2010-08-25  6:50   ` Avi Kivity [this message]
2010-08-25  7:05     ` Wei Yongjun
2010-08-25  7:06     ` [PATCHv2] " Wei Yongjun
2010-08-25 22:54 ` [PATCH] KVM: x86 emulator: add CALL FAR instruction emulation (opcode 9a) Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C74BD47.5030101@redhat.com \
    --to=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=yjwei@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox