Re: [PATCH kvm-unit-tests 07/10] Correct the tss size

[Avi Kivity <avi@redhat.com>]

  On 08/25/2010 12:40 PM, Jason Wang wrote:
> ----- "Avi Kivity"<avi@redhat.com>  wrote:
>
>> On 08/24/2010 04:47 PM, Jason Wang wrote:
>>> TSS size should be 104 byte.
>>>
>>> Signed-off-by: Jason Wang<jasowang@redhat.com>
>>> ---
>>>    x86/cstart64.S |    2 +-
>>>    1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/x86/cstart64.S b/x86/cstart64.S
>>> index 5d358ad..b871153 100644
>>> --- a/x86/cstart64.S
>>> +++ b/x86/cstart64.S
>>> @@ -69,7 +69,7 @@ tss:
>>>    	.long 0
>>>    	.quad ring0stacktop - i * 4096
>> ring 0 stack
>>
>>>    	.quad 0, 0, 0
>> rings 1, 2, 3 stack
> Hello avi:
>
> Rechek with the manual, there's no filed of RSP3. So this patch may
> make sense.

That is true.  But please redo it to remove one 0 from the line above, 
not from the IST.

> But unfortunately it breaks 64bit vmexit test. Triple
> fault happens in setup_args(). Any suggestions or is there any thing I
> missed?

No idea.  Can you post an ftrace of the crash?


-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.