From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH kvm-unit-tests 07/10] Correct the tss size Date: Wed, 25 Aug 2010 12:55:05 +0300 Message-ID: <4C74E879.5030406@redhat.com> References: <1843630855.510021282729229953.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Jason Wang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8767 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752696Ab0HYJzK (ORCPT ); Wed, 25 Aug 2010 05:55:10 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7P9t9m5024140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Aug 2010 05:55:10 -0400 In-Reply-To: <1843630855.510021282729229953.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/25/2010 12:40 PM, Jason Wang wrote: > ----- "Avi Kivity" wrote: > >> On 08/24/2010 04:47 PM, Jason Wang wrote: >>> TSS size should be 104 byte. >>> >>> Signed-off-by: Jason Wang >>> --- >>> x86/cstart64.S | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/x86/cstart64.S b/x86/cstart64.S >>> index 5d358ad..b871153 100644 >>> --- a/x86/cstart64.S >>> +++ b/x86/cstart64.S >>> @@ -69,7 +69,7 @@ tss: >>> .long 0 >>> .quad ring0stacktop - i * 4096 >> ring 0 stack >> >>> .quad 0, 0, 0 >> rings 1, 2, 3 stack > Hello avi: > > Rechek with the manual, there's no filed of RSP3. So this patch may > make sense. That is true. But please redo it to remove one 0 from the line above, not from the IST. > But unfortunately it breaks 64bit vmexit test. Triple > fault happens in setup_args(). Any suggestions or is there any thing I > missed? No idea. Can you post an ftrace of the crash? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.