From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 3/3] KVM: x86 emulator: trap and propagate #DE from DIV
 and IDIV
Date: Thu, 26 Aug 2010 11:23:49 +0300
Message-ID: <4C762495.7050203@redhat.com>
References: <1282648229-19575-1-git-send-email-avi@redhat.com> <1282648229-19575-4-git-send-email-avi@redhat.com> <20100825210501.GD32737@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20100825210501.GD32737@amt.cnet>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

  On 08/26/2010 12:05 AM, Marcelo Tosatti wrote:
>
>> @@ -3363,7 +3374,7 @@ special_insn:
>>   		break;
>>   	case 0xf6 ... 0xf7:	/* Grp3 */
>>   		if (emulate_grp3(ctxt, ops) != X86EMUL_CONTINUE)
>> -			goto cannot_emulate;
>> +			goto done;
>>   		break;
> Must assign rc to emulate_grp3() retval.

While there's not much difference between X86EMUL_PROPAGATE_FAULT and 
X86EMUL_CONTINUE, it's bad form to break things internally.  I'll fix 
and repost.

-- 
error compiling committee.c: too many arguments to function