From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/8] KVM: x86 emulator: simplify ALU block (opcodes 00-3F) decode flags Date: Thu, 26 Aug 2010 11:26:38 +0300 Message-ID: <4C76253E.5080309@redhat.com> References: <1282561577-24491-1-git-send-email-avi@redhat.com> <1282561577-24491-3-git-send-email-avi@redhat.com> <20100825193922.GA31337@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:6568 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753104Ab0HZI0k (ORCPT ); Thu, 26 Aug 2010 04:26:40 -0400 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7Q8QeUI005884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Aug 2010 04:26:40 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7Q8QdQc023681 for ; Thu, 26 Aug 2010 04:26:40 -0400 In-Reply-To: <20100825193922.GA31337@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On 08/25/2010 10:39 PM, Marcelo Tosatti wrote: > >> /* 0x20 - 0x27 */ >> - D(ByteOp | DstMem | SrcReg | ModRM | Lock), D(DstMem | SrcReg | ModRM | Lock), >> - D(ByteOp | DstReg | SrcMem | ModRM), D(DstReg | SrcMem | ModRM), >> - D(ByteOp | DstAcc | SrcImmByte), D(DstAcc | SrcImm), N, N, >> + D2bv(DstMem | SrcReg | ModRM | Lock), D2bv(DstReg | SrcMem | ModRM), >> + D2bv(DstAcc | SrcImmByte), N, N, > SrcImm? opcode 0x25... > Ouch! -- error compiling committee.c: too many arguments to function