From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Yongjun Subject: Re: [PATCH v2 6/8] KVM: x86 emulator: simplify instruction decode flags for opcodes C0-DF Date: Thu, 26 Aug 2010 16:47:00 +0800 Message-ID: <4C762A04.6020304@cn.fujitsu.com> References: <1282811774-16534-1-git-send-email-avi@redhat.com> <1282811774-16534-7-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:55475 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752495Ab0HZIsp (ORCPT ); Thu, 26 Aug 2010 04:48:45 -0400 In-Reply-To: <1282811774-16534-7-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: > Use the new byte/word dual opcode decode. > > Signed-off-by: Avi Kivity > --- > arch/x86/kvm/emulate.c | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 935f98e..2610fc5 100644 > --- a/arch/x86/kvm/emulate.c > +++ b/arch/x86/kvm/emulate.c > @@ -2466,17 +2466,16 @@ static struct opcode opcode_table[256] = { > /* 0xB8 - 0xBF */ > X8(D(DstReg | SrcImm | Mov)), > /* 0xC0 - 0xC7 */ > - D(ByteOp | DstMem | SrcImm | ModRM), D(DstMem | SrcImmByte | ModRM), > + D2bv(DstMem | SrcImm | ModRM), > 0xC1 takes imm8 as the source operand. So D2bv can not be used here. > I(ImplicitOps | Stack | SrcImmU16, em_ret_near_imm), > D(ImplicitOps | Stack), > D(DstReg | SrcMemFAddr | ModRM | No64), D(DstReg | SrcMemFAddr | ModRM | No64), > - D(ByteOp | DstMem | SrcImm | ModRM | Mov), D(DstMem | SrcImm | ModRM | Mov), > + D2bv(DstMem | SrcImm | ModRM | Mov), > /* 0xC8 - 0xCF */ > N, N, N, D(ImplicitOps | Stack), > D(ImplicitOps), D(SrcImmByte), D(ImplicitOps | No64), D(ImplicitOps), > /* 0xD0 - 0xD7 */ > - D(ByteOp | DstMem | SrcOne | ModRM), D(DstMem | SrcOne | ModRM), > - D(ByteOp | DstMem | ModRM), D(DstMem | ModRM), > + D2bv(DstMem | SrcOne | ModRM), D2bv(DstMem | ModRM), > N, N, N, N, > /* 0xD8 - 0xDF */ > N, N, N, N, N, N, N, N, >