From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [RFC 2/7] change headers preparing for steal time Date: Thu, 26 Aug 2010 17:04:02 -0400 Message-ID: <4C76D6C2.3010608@redhat.com> References: <1282772597-4183-1-git-send-email-glommer@redhat.com> <1282772597-4183-2-git-send-email-glommer@redhat.com> <1282772597-4183-3-git-send-email-glommer@redhat.com> <4C76D22D.9010007@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com To: Zachary Amsden Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13961 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369Ab0HZVEE (ORCPT ); Thu, 26 Aug 2010 17:04:04 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7QL44YQ003837 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Aug 2010 17:04:04 -0400 In-Reply-To: <4C76D22D.9010007@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/26/2010 04:44 PM, Zachary Amsden wrote: > On 08/25/2010 11:43 AM, Glauber Costa wrote: >> This guest/host common patch prepares infrastructure for >> the steal time implementation. Some constants are added, >> and a name change happens in pvclock vcpu structure. >> >> Signed-off-by: Glauber Costa >> --- >> arch/x86/include/asm/kvm_para.h | 1 + >> arch/x86/include/asm/pvclock-abi.h | 4 +++- >> 2 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/arch/x86/include/asm/kvm_para.h >> b/arch/x86/include/asm/kvm_para.h >> index 05eba5e..1759c81 100644 >> --- a/arch/x86/include/asm/kvm_para.h >> +++ b/arch/x86/include/asm/kvm_para.h >> @@ -25,6 +25,7 @@ >> * in pvclock structure. If no bits are set, all flags are ignored. >> */ >> #define KVM_FEATURE_CLOCKSOURCE_STABLE_BIT 24 >> +#define KVM_FEATURE_CLOCKSOURCE_STEAL_BIT 25 >> >> #define MSR_KVM_WALL_CLOCK 0x11 >> #define MSR_KVM_SYSTEM_TIME 0x12 >> diff --git a/arch/x86/include/asm/pvclock-abi.h >> b/arch/x86/include/asm/pvclock-abi.h >> index 35f2d19..417061b 100644 >> --- a/arch/x86/include/asm/pvclock-abi.h >> +++ b/arch/x86/include/asm/pvclock-abi.h >> @@ -24,7 +24,7 @@ >> >> struct pvclock_vcpu_time_info { >> u32 version; >> - u32 pad0; >> + u32 steal_time; >> u64 tsc_timestamp; >> u64 system_time; >> u32 tsc_to_system_mul; >> @@ -40,5 +40,7 @@ struct pvclock_wall_clock { >> } __attribute__((__packed__)); >> >> #define PVCLOCK_TSC_STABLE_BIT (1<< 0) >> +#define PVCLOCK_STEAL_BIT (2<< 0) >> + >> #endif /* __ASSEMBLY__ */ >> #endif /* _ASM_X86_PVCLOCK_ABI_H */ > > > Will 32 bits be enough? Good question. Reading the rest of the code, I suspect it won't be, but Glauber will know better. -- All rights reversed