From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [RFC 4/7] change kernel accounting to include steal time Date: Thu, 26 Aug 2010 16:14:47 -0500 Message-ID: <4C76D947.4030105@codemonkey.ws> References: <1282772597-4183-1-git-send-email-glommer@redhat.com> <1282772597-4183-2-git-send-email-glommer@redhat.com> <1282772597-4183-3-git-send-email-glommer@redhat.com> <1282772597-4183-4-git-send-email-glommer@redhat.com> <1282772597-4183-5-git-send-email-glommer@redhat.com> <20100826172303.GB21273@amt.cnet> <20100826202856.GC2985@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org, avi@redhat.com, zamsden@redhat.com, riel@redhat.com To: Glauber Costa Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:34552 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753720Ab0HZVOu (ORCPT ); Thu, 26 Aug 2010 17:14:50 -0400 Received: by qwh6 with SMTP id 6so2065398qwh.19 for ; Thu, 26 Aug 2010 14:14:50 -0700 (PDT) In-Reply-To: <20100826202856.GC2985@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 08/26/2010 03:28 PM, Glauber Costa wrote: > >> + if (delta> 1000UL) >> + touch_softlockup_watchdog(); >> + >> >> This will break authentic soft lockup detection whenever qemu processing >> takes more than 1s. >> > This should be 10s. 1000UL is a typo. > I was wondering that when I first saw the patch.. 10s is the default detection time but it's actually run time configurable so hard coding 10s is not correct. Regards, Anthony Liguori