From: Jes Sorensen <Jes.Sorensen@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, gleb@redhat.com
Subject: Re: [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX
Date: Fri, 27 Aug 2010 11:41:01 +0200 [thread overview]
Message-ID: <4C77882D.7000308@redhat.com> (raw)
In-Reply-To: <4C778386.8090902@redhat.com>
On 08/27/10 11:21, Avi Kivity wrote:
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index cf56462..8e95371 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -2888,6 +2888,8 @@ static void vmx_inject_nmi(struct kvm_vcpu *vcpu)
>> kvm_rip_write(vcpu, vmx->rmode.irq.rip - 1);
>> return;
>> }
>> + vmcs_write32(GUEST_INTERRUPTIBILITY_INFO,
>> + vmcs_read32(GUEST_INTERRUPTIBILITY_INFO)&
>> ~GUEST_INTR_STATE_STI);
>
> vmcs_clear_bits() is a nicer way of doing this.
>
Ok, try v2 that I just posted - and forgot to add v2 in the Subject line
to - sorry.
Cheers,
Jes
next prev parent reply other threads:[~2010-08-27 9:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-26 20:06 [PATCH 0/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to VMX guest Jes.Sorensen
2010-08-26 20:06 ` [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX Jes.Sorensen
2010-08-27 8:27 ` Jan Kiszka
2010-08-27 8:31 ` Jes Sorensen
2010-08-27 8:39 ` Jan Kiszka
2010-08-27 9:46 ` Avi Kivity
2010-08-27 11:06 ` Jan Kiszka
2010-08-27 13:58 ` Avi Kivity
2010-08-27 14:13 ` Jan Kiszka
2010-08-27 15:50 ` Avi Kivity
2010-08-27 16:43 ` Jan Kiszka
2010-08-29 8:09 ` Avi Kivity
2010-08-27 9:44 ` Avi Kivity
2010-08-27 11:06 ` Jan Kiszka
2010-08-27 13:54 ` Avi Kivity
2010-08-27 14:12 ` Jan Kiszka
2010-08-27 11:16 ` Gleb Natapov
2010-08-27 11:23 ` Jan Kiszka
2010-08-27 11:25 ` Gleb Natapov
2010-08-27 11:04 ` Gleb Natapov
2010-08-27 11:09 ` Jan Kiszka
2010-08-27 9:21 ` Avi Kivity
2010-08-27 9:41 ` Jes Sorensen [this message]
2010-08-27 9:47 ` Avi Kivity
2010-08-27 9:56 ` Jes Sorensen
2010-08-27 9:59 ` Avi Kivity
2010-08-27 10:01 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C77882D.7000308@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox