From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX Date: Fri, 27 Aug 2010 12:46:02 +0300 Message-ID: <4C77895A.1000708@redhat.com> References: <1282853162-16925-1-git-send-email-Jes.Sorensen@redhat.com> <1282853162-16925-2-git-send-email-Jes.Sorensen@redhat.com> <4C7776F9.4070306@siemens.com> <4C7777CA.4010208@redhat.com> <4C7779D2.9090902@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: Jes Sorensen , "kvm@vger.kernel.org" , "gleb@redhat.com" To: Jan Kiszka Return-path: Received: from mx1.redhat.com ([209.132.183.28]:24184 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754696Ab0H0JqH (ORCPT ); Fri, 27 Aug 2010 05:46:07 -0400 In-Reply-To: <4C7779D2.9090902@siemens.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/27/2010 11:39 AM, Jan Kiszka wrote: > > AMD does not differentiate between MOV-SS and STI interrupt shadows. > > But AMD has its own NMI problems as it does not allow to trap after > IRET-from-NMI and requires magic dances which are partly broken in KVM. > I'm leaning towards NMI window emulation via the workaround we use for > older Intel CPUs without NMI window trapping as well. Can you elaborate? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.