From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX Date: Fri, 27 Aug 2010 12:59:54 +0300 Message-ID: <4C778C9A.1030104@redhat.com> References: <1282853162-16925-1-git-send-email-Jes.Sorensen@redhat.com> <1282853162-16925-2-git-send-email-Jes.Sorensen@redhat.com> <4C778386.8090902@redhat.com> <4C77882D.7000308@redhat.com> <4C7789B5.8040707@redhat.com> <4C778BCA.1000106@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, gleb@redhat.com To: Jes Sorensen Return-path: Received: from mx1.redhat.com ([209.132.183.28]:38327 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750986Ab0H0J76 (ORCPT ); Fri, 27 Aug 2010 05:59:58 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7R9xvZn012169 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 27 Aug 2010 05:59:58 -0400 In-Reply-To: <4C778BCA.1000106@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/27/2010 12:56 PM, Jes Sorensen wrote: > >> Well, in light of Jan's comment re sti; hlt being clobbered by this, we >> should think about requesting an interrupt window instead... >> > Ok, I heading onto thin ice here :) > > How does one do that, just a call to > kvm_x86_ops->enable_nmi_window(vcpu); > or is something else needed, like setting vcpu->arch.nmi_pending ? ->enable_irq_window() And need to update ->nmi_allowed() to disallow nmi if blocked-by-sti. I've asked the vendor about this, so let's wait for their reply first. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.