From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Kiszka Subject: Re: [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting NMI to guest on VMX Date: Fri, 27 Aug 2010 13:09:09 +0200 Message-ID: <4C779CD5.5000307@siemens.com> References: <1282853162-16925-1-git-send-email-Jes.Sorensen@redhat.com> <1282853162-16925-2-git-send-email-Jes.Sorensen@redhat.com> <4C7776F9.4070306@siemens.com> <20100827110459.GA21909@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Jes.Sorensen@redhat.com" , "kvm@vger.kernel.org" , "avi@redhat.com" To: Gleb Natapov Return-path: Received: from goliath.siemens.de ([192.35.17.28]:22552 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753804Ab0H0LJY (ORCPT ); Fri, 27 Aug 2010 07:09:24 -0400 In-Reply-To: <20100827110459.GA21909@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: Gleb Natapov wrote: > On Fri, Aug 27, 2010 at 10:27:37AM +0200, Jan Kiszka wrote: >> Am 26.08.2010 22:06, Jes.Sorensen@redhat.com wrote: >>> From: Jes Sorensen >>> >>> Injecting an NMI while GUEST_INTR_STATE_STI is set may fail, >>> which can cause an EXIT with invalid state, resulting in the >>> guest dieing. >> Very interesting. Reality obviously doesn't bother about the statement >> of the vendor [1]. >> > I re-read my mail thread with vendor and to be fair vendor said that we should > clear blocked by STI before injecting NMI. It's my fault I missed it. Ah, ok, then I take this back. Still, this leaves blocked-by-STI useless when NMIs are present. We are somehow in the same troubles as on AMD. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux