From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH 1/1] Disable GUEST_INTR_STATE_STI flag before injecting
 NMI to guest on VMX
Date: Fri, 27 Aug 2010 16:54:33 +0300
Message-ID: <4C77C399.40207@redhat.com>
References: <1282853162-16925-1-git-send-email-Jes.Sorensen@redhat.com> <1282853162-16925-2-git-send-email-Jes.Sorensen@redhat.com> <4C7776F9.4070306@siemens.com> <4C778909.2030509@redhat.com> <4C779C3A.5050507@siemens.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Jes.Sorensen@redhat.com" <Jes.Sorensen@redhat.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"gleb@redhat.com" <gleb@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:65099 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753786Ab0H0Nyk (ORCPT <rfc822;kvm@vger.kernel.org>);
	Fri, 27 Aug 2010 09:54:40 -0400
In-Reply-To: <4C779C3A.5050507@siemens.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

  On 08/27/2010 02:06 PM, Jan Kiszka wrote:
>
>> Wow.  Maybe we should request an interrupt window instead when
>> blocked-by-STI is active instead of clearing it.
>>
> Then we are (almost) back in pre-NMI-window times when the guest happens
> to spin with IRQs disabled.

No.  We only request an interrupt window if we're blocked by STI.  That 
implies that interrupts will be enabled by the next instruction.

(except if the code is sti; cli?)

Is there anything in x86 that doesn't suck?

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.