From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rik van Riel Subject: Re: [RFC 4/7] change kernel accounting to include steal time Date: Sun, 29 Aug 2010 11:42:35 -0400 Message-ID: <4C7A7FEB.4040305@redhat.com> References: <1282772597-4183-1-git-send-email-glommer@redhat.com> <1282772597-4183-2-git-send-email-glommer@redhat.com> <1282772597-4183-3-git-send-email-glommer@redhat.com> <1282772597-4183-4-git-send-email-glommer@redhat.com> <1282772597-4183-5-git-send-email-glommer@redhat.com> <4C7A2F88.6050807@redhat.com> <4C7A7907.2030405@redhat.com> <4C7A7BCF.4050206@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Glauber Costa , kvm@vger.kernel.org, zamsden@redhat.com, mtosatti@redhat.com To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41481 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753718Ab0H2Pmi (ORCPT ); Sun, 29 Aug 2010 11:42:38 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7TFgbb9032223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 29 Aug 2010 11:42:38 -0400 In-Reply-To: <4C7A7BCF.4050206@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/29/2010 11:25 AM, Avi Kivity wrote: > On 08/29/2010 06:13 PM, Rik van Riel wrote: >> >>> Since s390 does steal time (I think?), can this code be shared? >> >> That part already is shared. Glauber's patches reuse the same >> code that s390 and Xen use. >> > > Why can't we use the same approach as s390 and ppc (calling > account_steal_time from the timer interrupt)? or perhaps those should be > moved into the scheduler proper? Now that is a good question. > Didn't find the Xen hooks. I suspect Xen lost them in the paravirt ops port... -- All rights reversed