From: Avi Kivity <avi@redhat.com>
To: kvm@vger.kernel.org, Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH] KVM: i8259: initialize IMR to 0xff on reset
Date: Mon, 30 Aug 2010 12:22:00 +0300 [thread overview]
Message-ID: <4C7B7838.1010709@redhat.com> (raw)
In-Reply-To: <1283160031-13505-1-git-send-email-avi@redhat.com>
On 08/30/2010 12:20 PM, Avi Kivity wrote:
> Otherwise, a wily interrupt can slip through while the guest isn't prepared
> for it (and while the irq base is zero).
>
>
> s->last_irr = 0;
> s->irr = 0;
> - s->imr = 0;
> + s->imr = 0xff;
> s->isr = 0;
> s->isr_ack = 0xff;
> s->priority_add = 0;
For some reason, this bug only shows on the non-atomic-injection branch
(specifically, the KVM_REQ_EVENT part).
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-08-30 9:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 9:20 [PATCH] KVM: i8259: initialize IMR to 0xff on reset Avi Kivity
2010-08-30 9:22 ` Avi Kivity [this message]
2010-08-30 13:36 ` Paolo Bonzini
2010-08-30 13:53 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7B7838.1010709@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox