From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: i8259: initialize IMR to 0xff on reset Date: Mon, 30 Aug 2010 12:22:00 +0300 Message-ID: <4C7B7838.1010709@redhat.com> References: <1283160031-13505-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: kvm@vger.kernel.org, Marcelo Tosatti Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2712 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755007Ab0H3JWB (ORCPT ); Mon, 30 Aug 2010 05:22:01 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7U9M1HK029729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Aug 2010 05:22:01 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7U9M0gO003659 for ; Mon, 30 Aug 2010 05:22:01 -0400 In-Reply-To: <1283160031-13505-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/30/2010 12:20 PM, Avi Kivity wrote: > Otherwise, a wily interrupt can slip through while the guest isn't prepared > for it (and while the irq base is zero). > > > s->last_irr = 0; > s->irr = 0; > - s->imr = 0; > + s->imr = 0xff; > s->isr = 0; > s->isr_ack = 0xff; > s->priority_add = 0; For some reason, this bug only shows on the non-atomic-injection branch (specifically, the KVM_REQ_EVENT part). -- error compiling committee.c: too many arguments to function