From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC 2/7] change headers preparing for steal time Date: Mon, 30 Aug 2010 16:10:41 +0300 Message-ID: <4C7BADD1.4080900@redhat.com> References: <1282772597-4183-1-git-send-email-glommer@redhat.com> <1282772597-4183-2-git-send-email-glommer@redhat.com> <1282772597-4183-3-git-send-email-glommer@redhat.com> <4C7A2DAC.8090903@redhat.com> <20100830124448.GB17084@mothafucka.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, zamsden@redhat.com, mtosatti@redhat.com, riel@redhat.com To: Glauber Costa Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58021 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754651Ab0H3NKo (ORCPT ); Mon, 30 Aug 2010 09:10:44 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7UDAh9p006633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Aug 2010 09:10:43 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7UDAg9r004595 for ; Mon, 30 Aug 2010 09:10:43 -0400 In-Reply-To: <20100830124448.GB17084@mothafucka.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 08/30/2010 03:44 PM, Glauber Costa wrote: > @@ -40,5 +40,7 @@ struct pvclock_wall_clock { >>> } __attribute__((__packed__)); >>> >>> #define PVCLOCK_TSC_STABLE_BIT (1<< 0) >>> +#define PVCLOCK_STEAL_BIT (2<< 0) >>> + >>> #endif /* __ASSEMBLY__ */ >>> #endif /* _ASM_X86_PVCLOCK_ABI_H */ >> We could extend pvclock to 64 bytes (unfortunately we didn't reserve >> bits 0-5 like we did with others) and use an nsec field. > Yes we could, but what for? > We're in a jiffie resolution on the other side anyway. "the other side" keeps changing (and is potentially not just Linux). We need to be prepared for the future. We'll regret having an interface that matches Linux at a random in time but nothing else. -- error compiling committee.c: too many arguments to function