From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: i8259: Make ICW1 conform to spec Date: Mon, 30 Aug 2010 17:57:09 +0300 Message-ID: <4C7BC6C5.1000205@redhat.com> References: <1283179605-25504-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Marcelo Tosatti , kvm@vger.kernel.org, Paolo Bonzini Return-path: Received: from mx1.redhat.com ([209.132.183.28]:25560 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751969Ab0H3O5L (ORCPT ); Mon, 30 Aug 2010 10:57:11 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7UEvBOC018178 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 30 Aug 2010 10:57:11 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o7UEvASx017820 for ; Mon, 30 Aug 2010 10:57:10 -0400 In-Reply-To: <1283179605-25504-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/30/2010 05:46 PM, Avi Kivity wrote: > ICW is not a full reset, instead it resets a limited number of registers > in the PIC. Change ICW1 emulation to only reset those registers. > The non-atomic-injection branch seems to be happy with this. -- error compiling committee.c: too many arguments to function