From: Avi Kivity <avi@redhat.com>
To: Zachary Amsden <zamsden@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
mtosatti@redhat.com, kvm <kvm@vger.kernel.org>,
Chris Lalancette <clalance@redhat.com>
Subject: Re: [PATCH] KVM: pit: Do not check pending pit timer in vcpu thread
Date: Tue, 31 Aug 2010 09:25:55 +0300 [thread overview]
Message-ID: <4C7CA073.1050906@redhat.com> (raw)
In-Reply-To: <4C7C23AD.3090907@redhat.com>
On 08/31/2010 12:33 AM, Zachary Amsden wrote:
> On 08/26/2010 11:15 PM, Jason Wang wrote:
>> Pit interrupt injection was done by workqueue, so no need to check
>> pending pit timer in vcpu thread which could lead unnecessary
>> unblocking of vcpu.
>
> Is this actually correct? There were a bunch of workarounds and fixes
> put into this code over time. Please check with Chris Lalancette, I
> think he was the last to touch this code.
Once upon a time we injected PIT interrupts from the vcpu thread (even
though the PIT is external to any vcpu) which let to a lot of
complications in the implementation. This patch removes one of them.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2010-08-31 6:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 9:15 [PATCH] KVM: pit: Do not check pending pit timer in vcpu thread Jason Wang
2010-08-27 17:10 ` Marcelo Tosatti
2010-08-29 9:04 ` Avi Kivity
2010-08-30 21:33 ` Zachary Amsden
2010-08-31 6:25 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C7CA073.1050906@redhat.com \
--to=avi@redhat.com \
--cc=clalance@redhat.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=zamsden@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox