From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 0/5] virtio-net: More configurability and bh handling for tx Date: Tue, 31 Aug 2010 16:33:15 -0500 Message-ID: <4C7D751B.8070705@codemonkey.ws> References: <20100827223659.2696.3589.stgit@s20.home> <20100831202705.GE31570@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Alex Williamson , qemu-devel@nongnu.org, kvm@vger.kernel.org, jes.sorensen@redhat.com, kraxel@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:54829 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750721Ab0HaVdr (ORCPT ); Tue, 31 Aug 2010 17:33:47 -0400 Received: by qwh6 with SMTP id 6so5648780qwh.19 for ; Tue, 31 Aug 2010 14:33:47 -0700 (PDT) In-Reply-To: <20100831202705.GE31570@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/31/2010 03:27 PM, Michael S. Tsirkin wrote: > On Fri, Aug 27, 2010 at 04:36:59PM -0600, Alex Williamson wrote: > >> Add the ability to configure the tx_timer timeout and add a bottom >> half tx handler that typically shows a nice perf boost over the >> time based approach. See last patch for perf details. Make this >> the new default when the iothread is enabled. Thanks, >> >> Alex >> > As a further thought, maybe it would help to have a > separate namespace for unsupported, developer-only parameters. > Thoughts? > We already have an undocumented one, just prefix with 'x-' to indicate that it's experimental. Regards, Anthony Liguori > >> --- >> >> Alex Williamson (5): >> virtio-net: Switch default to new bottom half TX handler for iothread >> virtio-net: Introduce a new bottom half packet TX >> virtio-net: Rename tx_timer_active to tx_waiting >> virtio-net: Limit number of packets sent per TX flush >> virtio-net: Make tx_timer timeout configurable >> >> >> hw/s390-virtio-bus.c | 6 ++ >> hw/s390-virtio-bus.h | 4 ++ >> hw/syborg_virtio.c | 10 +++- >> hw/virtio-net.c | 129 ++++++++++++++++++++++++++++++++++++++++---------- >> hw/virtio-net.h | 2 - >> hw/virtio-pci.c | 10 +++- >> hw/virtio.h | 9 +++ >> 7 files changed, 137 insertions(+), 33 deletions(-) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe kvm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >>