From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kernelshark plugins and ftrace array fields Date: Thu, 02 Sep 2010 17:34:43 +0300 Message-ID: <4C7FB603.60609@redhat.com> References: <4C7F9639.7000804@redhat.com> <1283437521.2356.136.camel@gandalf.stny.rr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-kernel , KVM list To: Steven Rostedt Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58993 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754163Ab0IBOeq (ORCPT ); Thu, 2 Sep 2010 10:34:46 -0400 In-Reply-To: <1283437521.2356.136.camel@gandalf.stny.rr.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/02/2010 05:25 PM, Steven Rostedt wrote: > On Thu, 2010-09-02 at 15:19 +0300, Avi Kivity wrote: >> I'd like to add enhance kvm_emulate_insn display in kernelshark to >> show the disassembly of the instruction being emulated. However, >> pevent_get_field_val() doesn't support arrays (the instruction is >> provided in a 15-byte array). >> >> Can you add support for arrays in the kernelshark API? With that, it >> looks like adding disassembly output to the kvm plugin should be quite >> simple. >> > Sure, I could add a pevent_get_field_array() or something. Could you > tell me the event and give me an example of what you want to do. plugin_kvm.c: kvm_emulate_insn_handler() { fetch insn array and len field feed into disassembler trace_seq_printf() the disassembled instruction } -- error compiling committee.c: too many arguments to function