From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hidetoshi Seto Subject: Re: [PATCH] Use signed 16-bit values for ivshmem register writes Date: Fri, 03 Sep 2010 10:53:59 +0900 Message-ID: <4C805537.6080409@jp.fujitsu.com> References: <1283187480-23563-1-git-send-email-cam@cs.ualberta.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Hao, Xudong" To: Cam Macdonell Return-path: Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:58027 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503Ab0ICByf (ORCPT ); Thu, 2 Sep 2010 21:54:35 -0400 Received: from m5.gw.fujitsu.co.jp ([10.0.50.75]) by fgwmail7.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o831sXg2019057 for (envelope-from seto.hidetoshi@jp.fujitsu.com); Fri, 3 Sep 2010 10:54:33 +0900 Received: from smail (m5 [127.0.0.1]) by outgoing.m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 7C8E645DE51 for ; Fri, 3 Sep 2010 10:54:33 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (s5.gw.fujitsu.co.jp [10.0.50.95]) by m5.gw.fujitsu.co.jp (Postfix) with ESMTP id 595FF45DE4F for ; Fri, 3 Sep 2010 10:54:33 +0900 (JST) Received: from s5.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id 433FD1DB8040 for ; Fri, 3 Sep 2010 10:54:33 +0900 (JST) Received: from m106.s.css.fujitsu.com (m106.s.css.fujitsu.com [10.249.87.106]) by s5.gw.fujitsu.co.jp (Postfix) with ESMTP id EAA761DB803C for ; Fri, 3 Sep 2010 10:54:32 +0900 (JST) In-Reply-To: <1283187480-23563-1-git-send-email-cam@cs.ualberta.ca> Sender: kvm-owner@vger.kernel.org List-ID: (2010/08/31 1:58), Cam Macdonell wrote: > fixes gcc 4.1 warning > > Signed-off-by: Cam Macdonell > --- > hw/ivshmem.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/ivshmem.c b/hw/ivshmem.c > index bbb5cba..fa9c684 100644 > --- a/hw/ivshmem.c > +++ b/hw/ivshmem.c > @@ -181,8 +181,8 @@ static void ivshmem_io_writel(void *opaque, target_phys_addr_t addr, > IVShmemState *s = opaque; > > uint64_t write_one = 1; > - uint16_t dest = val >> 16; > - uint16_t vector = val & 0xff; > + int16_t dest = val >> 16; > + int16_t vector = val & 0xff; > > addr &= 0xfc; > Since val is uint32_t, I think this change doesn't make sense. Thanks, H.Seto