From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hidetoshi Seto Subject: [PATCH] ivshmem: remove unnecessary checks for unsigned Date: Fri, 03 Sep 2010 10:54:35 +0900 Message-ID: <4C80555B.102@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: Cam Macdonell , "Hao, Xudong" To: kvm@vger.kernel.org, qemu-devel@nongnu.org Return-path: Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:56892 "EHLO fgwmail6.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752998Ab0ICBys (ORCPT ); Thu, 2 Sep 2010 21:54:48 -0400 Received: from m4.gw.fujitsu.co.jp ([10.0.50.74]) by fgwmail6.fujitsu.co.jp (Fujitsu Gateway) with ESMTP id o831slYF019446 for (envelope-from seto.hidetoshi@jp.fujitsu.com); Fri, 3 Sep 2010 10:54:47 +0900 Received: from smail (m4 [127.0.0.1]) by outgoing.m4.gw.fujitsu.co.jp (Postfix) with ESMTP id 0BEEC45DE70 for ; Fri, 3 Sep 2010 10:54:47 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (s4.gw.fujitsu.co.jp [10.0.50.94]) by m4.gw.fujitsu.co.jp (Postfix) with ESMTP id DF7AB45DE6E for ; Fri, 3 Sep 2010 10:54:46 +0900 (JST) Received: from s4.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id A88361DB8037 for ; Fri, 3 Sep 2010 10:54:46 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.249.87.107]) by s4.gw.fujitsu.co.jp (Postfix) with ESMTP id 0899A1DB8043 for ; Fri, 3 Sep 2010 10:54:46 +0900 (JST) Sender: kvm-owner@vger.kernel.org List-ID: fixes gcc 4.1 warning: In function 'ivshmem_io_writel': 202: warning: comparison is always false due to limited range of data type 208: warning: comparison is always true due to limited range of data type Signed-off-by: Hidetoshi Seto --- hw/ivshmem.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ivshmem.c b/hw/ivshmem.c index bbb5cba..afebbc3 100644 --- a/hw/ivshmem.c +++ b/hw/ivshmem.c @@ -199,13 +199,13 @@ static void ivshmem_io_writel(void *opaque, target_phys_addr_t addr, case DOORBELL: /* check that dest VM ID is reasonable */ - if ((dest < 0) || (dest > s->max_peer)) { + if (dest > s->max_peer) { IVSHMEM_DPRINTF("Invalid destination VM ID (%d)\n", dest); break; } /* check doorbell range */ - if ((vector >= 0) && (vector < s->peers[dest].nb_eventfds)) { + if (vector < s->peers[dest].nb_eventfds) { IVSHMEM_DPRINTF("Writing %" PRId64 " to VM %d on vector %d\n", write_one, dest, vector); if (write(s->peers[dest].eventfds[vector], -- 1.7.2.2