From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [patch 1/3] kvm test: add monitor_printf Date: Fri, 03 Sep 2010 09:56:51 +0200 Message-ID: <4C80AA43.20904@redhat.com> References: <20100902233652.853027771@redhat.com> <20100902233712.666073971@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Marcelo Tosatti Return-path: Received: from mail-qy0-f174.google.com ([209.85.216.174]:40989 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753448Ab0ICH4z (ORCPT ); Fri, 3 Sep 2010 03:56:55 -0400 Received: by qyk36 with SMTP id 36so2977077qyk.19 for ; Fri, 03 Sep 2010 00:56:55 -0700 (PDT) In-Reply-To: <20100902233712.666073971@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/03/2010 01:36 AM, Marcelo Tosatti wrote: > +static void print_monitor(const char *buf) > +{ > + [...] > +} > + > +void puts_monitor(const char *s) > +{ > + spin_lock(&mon_lock); > + print_serial(s); ^^^^^^^^^^^^ Is this intended? Paolo