From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 3/4] x86: Fix allowed CPUID bits for KVM guests Date: Sun, 05 Sep 2010 11:11:49 +0300 Message-ID: <4C8350C5.7050302@redhat.com> References: <1283506069-1096-1-git-send-email-andre.przywara@amd.com> <1283506069-1096-4-git-send-email-andre.przywara@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: Andre Przywara Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47190 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753400Ab0IEILw (ORCPT ); Sun, 5 Sep 2010 04:11:52 -0400 In-Reply-To: <1283506069-1096-4-git-send-email-andre.przywara@amd.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/03/2010 12:27 PM, Andre Przywara wrote: > The AMD extension to AVX (FMA4, XOP) work on the same YMM register set > as AVX, so they are safe for guests to use, as long as AVX itself > is allowed. > > Signed-off-by: Andre Przywara > --- > arch/x86/kvm/x86.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 3a09c62..eb89e7b 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1996,8 +1996,8 @@ static void do_cpuid_ent(struct kvm_cpuid_entry2 *entry, u32 function, > const u32 kvm_supported_word6_x86_features = > F(LAHF_LM) | F(CMP_LEGACY) | F(SVM) | 0 /* ExtApicSpace */ | > F(CR8_LEGACY) | F(ABM) | F(SSE4A) | F(MISALIGNSSE) | > - F(3DNOWPREFETCH) | 0 /* OSVW */ | 0 /* IBS */ | F(SSE5) | > - 0 /* SKINIT */ | 0 /* WDT */; > + F(3DNOWPREFETCH) | 0 /* OSVW */ | 0 /* IBS */ | F(XOP) | > + 0 /* SKINIT, WDT, LWP */ | F(FMA4) | F(TBM); > Should be folded into patch 1 to avoid build breakage. Did we really enable "sse5" before xsave? That looks broken, but I guess no real harm if xsave itself is not enabled. -- error compiling committee.c: too many arguments to function