From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 0/4] Apply some CODING_STYLE to qemu-kvm*.c Date: Sun, 05 Sep 2010 15:29:15 +0300 Message-ID: <4C838D1B.5040103@redhat.com> References: <1283688837-3556-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Marcelo Tosatti , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:36039 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753168Ab0IEM3Q (ORCPT ); Sun, 5 Sep 2010 08:29:16 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o85CTGKN028545 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 5 Sep 2010 08:29:16 -0400 Received: from cleopatra.tlv.redhat.com (cleopatra.tlv.redhat.com [10.35.255.11]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o85CTFF2023434 for ; Sun, 5 Sep 2010 08:29:16 -0400 In-Reply-To: <1283688837-3556-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 09/05/2010 03:13 PM, Avi Kivity wrote: > Avi Kivity (4): > qemu-kvm-x86.c: reindent > qemu-kvm-x86.c: remove extraneous line continuation > qemu-kvm-x86.c: add braces where appropriate > qemu-kvm.c: add braces where appropriate > > qemu-kvm-x86.c | 909 +++++++++++++++++++++++++++++--------------------------- > qemu-kvm.c | 174 +++++++---- > 2 files changed, 586 insertions(+), 497 deletions(-) > Argh! send-before-save race. Original content: The qemu-kvm support files are really broken wrt CODING_STYLE. Fix up some of the breakage. -- error compiling committee.c: too many arguments to function